Skip to content

improved pagination buttons#1082

Merged
swapnilsparsh merged 4 commits intoswapnilsparsh:masterfrom
ratishjain12:pagination-fix
Oct 11, 2023
Merged

improved pagination buttons#1082
swapnilsparsh merged 4 commits intoswapnilsparsh:masterfrom
ratishjain12:pagination-fix

Conversation

@ratishjain12
Copy link
Contributor

@ratishjain12 ratishjain12 commented Oct 8, 2023

🛠️ Fixes Issue (Number)

@swapnilsparsh
Fixes #1071
Screenshot 2023-10-08 104038

image

I have enhanced pagination section kindly merge it :)

👨‍💻 Changes proposed and Brief Description

✅ Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for 30daysofjs ready!

Name Link
🔨 Latest commit cf8bf42
🔍 Latest deploy log https://app.netlify.com/sites/30daysofjs/deploys/6526832388b18900080fe7bb
😎 Deploy Preview https://deploy-preview-1082--30daysofjs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Resolve the conflicts.
  2. Make the active page number with some other background color to make it differ from others

@ratishjain12
Copy link
Contributor Author

ratishjain12 commented Oct 9, 2023

  1. Resolve the conflicts.
  2. Make the active page number with some other background color to make it differ from others

Sure just a sec will ping you when its done

Hey @swapnilsparsh can you please elaborate which conflicts you want me to reaolve

@swapnilsparsh
Copy link
Owner

@ratishjain12 you can check the conflicts above as I can merge your code unless conflicts are resolved.

@ratishjain12
Copy link
Contributor Author

@swapnilsparsh I think now there is no conflicts and I have added focus color on buttons :)

@swapnilsparsh
Copy link
Owner

@ratishjain12 When you open the website for the first time then by default page number 1 should be highlighted as page number 1 is opened.

@ratishjain12
Copy link
Contributor Author

Ok let me check

@ratishjain12
Copy link
Contributor Author

ratishjain12 commented Oct 10, 2023

@swapnilsparsh now its done :)

@swapnilsparsh
Copy link
Owner

@ratishjain12 Clicking on Previous or Next button then highlight is not working. Also If you click anywhere on the page then also highlight of the button gets removed.

@ratishjain12
Copy link
Contributor Author

ratishjain12 commented Oct 11, 2023

@ratishjain12 Clicking on Previous or Next button then highlight is not working. Also If you click anywhere on the page then also highlight of the button gets removed.

Ok I'll look into it @swapnilsparsh
So basically all I need to do is to maintain focus on clicking next and previous and also maintain the focus whenever someone clicks anywhere on the page right?

@ratishjain12
Copy link
Contributor Author

@swapnilsparsh I have finished all the things required page 1 by default is active on clicking next and prev the state is maintained as well as clicking anywhere else the focus is not getting removed.

Kindly merge thank you :)

@swapnilsparsh swapnilsparsh merged commit 248cfe6 into swapnilsparsh:master Oct 11, 2023
@swapnilsparsh
Copy link
Owner

@ratishjain12 Thank You for your contribution! Excited for more in the future! 🥂

@swapnilsparsh swapnilsparsh added hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted labels Oct 11, 2023
@ratishjain12
Copy link
Contributor Author

@ratishjain12 Thank You for your contribution! Excited for more in the future! 🥂

Mention not will do 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title: Improve pagination buttons styling and improve the footer section

2 participants