Skip to content

Conversation

@phoenix-web3
Copy link
Collaborator

@phoenix-web3 phoenix-web3 commented Mar 14, 2022

Description

  • Change LUNA host to accept requests by network
  • Change BCH host to accept requests by network
  • Change BTC host to accept requests by network
  • Change ETH host to accept requests by network
  • Change XMR host to accept requests by network

Also done:

  • Change BCH main service name from bitcoincore to bitcoinabc
  • Add logger for admin requests in scripts/endpoints.py
  • Increase the max complexity by 1 (script needed)
  • Update getBlockByHash and getBlockByNumber schemas
  • Fix unused LUNA and BCH method from handler.py
  • Remove hardcoded coins
  • Fixed typo in syncing method

Fixes #119 #120 (issue)

Dependencies (if any)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Related PR or Docs PR

Docs PR related #
Other PR related #

Good practices to consider

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@phoenix-web3 phoenix-web3 linked an issue Mar 14, 2022 that may be closed by this pull request
2 tasks
@phoenix-web3 phoenix-web3 marked this pull request as ready for review March 14, 2022 20:32
@phoenix-web3
Copy link
Collaborator Author

@bridgedragon Before merging this PR, can you test it on the server?

I suggest to use the new server. I've fixed some path bugs in the docker volumes of Bitcoin. This could break the synced volumes

@phoenix-web3 phoenix-web3 force-pushed the 119-mainnets-are-failing-with-testnet branch from 839fae8 to cd46956 Compare March 16, 2022 16:53
@phoenix-web3 phoenix-web3 merged commit d1ba72b into swapper-org:staging Mar 16, 2022
@phoenix-web3 phoenix-web3 deleted the 119-mainnets-are-failing-with-testnet branch June 13, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getBlockByNumber scheme is not working on eth mainnet Mainnets are failing with a testnet of the same currency running

1 participant