Skip to content

7 test coverage up to 80%#23

Merged
phoenix-web3 merged 42 commits intoswapper-org:stagingfrom
0xp3gasus:7-Test-coverage-up-to-80%
Nov 11, 2021
Merged

7 test coverage up to 80%#23
phoenix-web3 merged 42 commits intoswapper-org:stagingfrom
0xp3gasus:7-Test-coverage-up-to-80%

Conversation

@0xp3gasus
Copy link
Copy Markdown
Collaborator

@0xp3gasus 0xp3gasus commented Nov 1, 2021

Description

The tests of the RPC and Web sockets methods of the BTC and ETH packages in the corresponding Regtest network developed.

Can not be up to 80% until Web Sockets refactor

Bug solved at opening schemas files

Fixes #7
Fixes #19

Dependencies (if any)

  • Connector Python version changed from 3 to 3.7 because of web python module error
  • Connector requirements updated to run tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tests have been developed making requests to regtest nodes and comparing responses with Connector responses.
Packages used for tests: pytest and coverage

  • BTC Tests

BTC tests are developed in file Connector/tests/btc/test_btc.py

BTC Test Coverage v 1 1

  • ETH Tests

ETH tests are developed in file Connector/tests/eth/test_eth

ETH Test Coverage v 1 1

Circle CI workflow finished successfully

Connector V1 1 Tests

Test Configuration:
Tests run at Circle Ci virtual machine
Circle CI machine version

Good practices to consider

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@phoenix-web3 phoenix-web3 mentioned this pull request Nov 3, 2021
12 tasks
Copy link
Copy Markdown
Collaborator

@phoenix-web3 phoenix-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes explaining everything of testing part should be added to README.md before merging this PR.

At least, we need to explain how to execute locally lint and tests.

@0xp3gasus 0xp3gasus mentioned this pull request Nov 10, 2021
2 tasks
@0xp3gasus 0xp3gasus linked an issue Nov 10, 2021 that may be closed by this pull request
2 tasks
@phoenix-web3 phoenix-web3 merged commit cf9be36 into swapper-org:staging Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Linting Errors Test coverage up to 80%

2 participants