7 test coverage up to 80%#23
Merged
phoenix-web3 merged 42 commits intoswapper-org:stagingfrom Nov 11, 2021
0xp3gasus:7-Test-coverage-up-to-80%
Merged
7 test coverage up to 80%#23phoenix-web3 merged 42 commits intoswapper-org:stagingfrom 0xp3gasus:7-Test-coverage-up-to-80%
phoenix-web3 merged 42 commits intoswapper-org:stagingfrom
0xp3gasus:7-Test-coverage-up-to-80%
Conversation
added 16 commits
October 9, 2021 18:00
12 tasks
phoenix-web3
requested changes
Nov 3, 2021
Collaborator
phoenix-web3
left a comment
There was a problem hiding this comment.
Some changes explaining everything of testing part should be added to README.md before merging this PR.
At least, we need to explain how to execute locally lint and tests.
…ndle-kill-signals 29-Improve buildapi.py to handle kill signals
added 14 commits
November 9, 2021 13:35
…r-pegasus/NodeChain into 7-Test-coverage-up-to-80%
phoenix-web3
reviewed
Nov 9, 2021
Closed
2 tasks
phoenix-web3
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tests of the RPC and Web sockets methods of the BTC and ETH packages in the corresponding Regtest network developed.
Can not be up to 80% until Web Sockets refactor
Bug solved at opening schemas files
Fixes #7
Fixes #19
Dependencies (if any)
Type of change
How Has This Been Tested?
Tests have been developed making requests to regtest nodes and comparing responses with Connector responses.
Packages used for tests: pytest and coverage
BTC tests are developed in file
Connector/tests/btc/test_btc.pyETH tests are developed in file
Connector/tests/eth/test_ethCircle CI workflow finished successfully
Test Configuration:

Tests run at Circle Ci virtual machine
Good practices to consider