Conversation
|
@swar Here's an updated PR for only the |
reidhoch
changed the title
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
brandonhawi
left a comment
brandonhawi
left a comment
There was a problem hiding this comment.
Left a few comments, but awesome work so far.
Perhaps a more philosophical question from a library standpoint, but with this type of data perhaps we'd want to validate at the library level to ensure that users don't query for this data for unsupported past seasons? I'm sure the NBA API itself would error but perhaps the library's error will be more useful?
| } | ||
|
|
||
| # Initialize dataset attributes | ||
| self.league_leaders = None |
There was a problem hiding this comment.
| self.league_leaders = None | |
| self.leaders = None |
For consistency with the nba_api, might be better to just use their nomenclature. What do you think?
Also on a side note, why init to None here? It will always be set in load_response.
| ) | ||
|
|
||
|
|
||
| class GravityLeaders(Endpoint): |
There was a problem hiding this comment.
Should probably provide this class with a docstring?
| LEADER_FIELDS = ( | ||
| "PLAYERID", | ||
| "FIRSTNAME", | ||
| "LASTNAME", | ||
| "TEAMID", | ||
| "TEAMABBREVIATION", | ||
| "TEAMNAME", | ||
| "TEAMCITY", | ||
| "FRAMES", | ||
| "GRAVITYSCORE", | ||
| "AVGGRAVITYSCORE", | ||
| "ONBALLPERIMETERFRAMES", | ||
| "ONBALLPERIMETERGRAVITYSCORE", | ||
| "AVGONBALLPERIMETERGRAVITYSCORE", | ||
| "OFFBALLPERIMETERFRAMES", | ||
| "OFFBALLPERIMETERGRAVITYSCORE", | ||
| "AVGOFFBALLPERIMETERGRAVITYSCORE", | ||
| "ONBALLINTERIORFRAMES", | ||
| "ONBALLINTERIORGRAVITYSCORE", | ||
| "AVGONBALLINTERIORGRAVITYSCORE", | ||
| "OFFBALLINTERIORFRAMES", | ||
| "OFFBALLINTERIORGRAVITYSCORE", | ||
| "AVGOFFBALLINTERIORGRAVITYSCORE", | ||
| "GAMESPLAYED", | ||
| "MINUTES", | ||
| "PTS", | ||
| "REB", | ||
| "AST", | ||
| ) |
There was a problem hiding this comment.
While this is consistent with the rest of the codebase, can we consider having a single source of truth for the field names instead of two places (here and in the GravityLeaders class)?
|
Hey @brandonhawi please re-review when you get a moment. |
|
@brandonhawi do you have any concerns here? The MR looks good to me |
brandonhawi
left a comment
brandonhawi
left a comment
There was a problem hiding this comment.
LGTM! Thanks @reidhoch
3 participants
Added the new Gravity Leaders endpoint. The NBA defines Player Gravity as "Gravity quantifies how much a player pulls defenders towards them above expected, essentially measuring how much attention they draw compared to what the spacing on the floor predicts."