fix(graphql-codegen-client-preset): respect namingConvention config

[kdy1]

Fixes #521

Add namingConvention option to the SWC plugin to match the naming convention configured in codegen.ts. The default is now change-case-all#pascalCase (matching graphql-codegen's client-preset default), which correctly handles word boundaries in names like SomeEGRockets → SomeEgRocketsDocument.

Previously, the plugin used upperCaseFirst behavior (only capitalize first letter), causing mismatches when operation names contained consecutive uppercase letters.

Generated with Claude Code

[changeset-bot]

⚠️ No Changeset found

Latest commit: 332e70f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[claude]

Code Review

Thanks for this fix! The issue is real and the approach is generally sound. Here's my feedback:

Positive changes

• Fixes the typo capetalize → upper_case_first and improves the implementation to use chars() instead of byte-slicing (&s[..1]). The old code would panic on empty strings or multi-byte UTF-8 characters, so this is an important correctness fix.
• The to_pascal_case word-boundary detection logic is correct. I traced through SomeEGRockets:
  • e→E triggers lower→upper boundary → "Some"
  • G→R (uppercase+uppercase followed by lowercase) triggers the third condition → "EG"
  • Remaining: "Rockets"
  • Result: "SomeEgRockets" ✓

Concerns

1. Missing changeset

The changeset bot flagged this. This is a breaking change in default behavior — the default naming convention is changing from upperCaseFirst to pascalCase. Existing users whose operation names contain consecutive uppercase letters (like SomeEGRockets) will get different import names after upgrading, which will break their builds. This warrants at minimum a minor version bump with clear release notes, not just a patch.

2. Silent fallback for unrecognized conventions

fn apply_naming_convention(s: &str, naming_convention: &str) -> String {
    match naming_convention {
        "change-case-all#upperCaseFirst" => upper_case_first(s),
        _ => to_pascal_case(s),  // ← silently handles unknown conventions
    }
}

If a user sets namingConvention: "change-case-all#camelCase" (or any other valid graphql-codegen convention), they'll silently get pascal case instead. This could cause confusing build failures with no clear error. Consider returning an error or at least logging a warning for unrecognized conventions.

3. Re-implementing change-case-all behavior

Rather than re-implementing the pascal case algorithm, have you considered depending on the convert_case Rust crate? That said, I understand SWC WASM plugins sometimes have restricted dependency options, so this may not be practical — worth checking though.

4. Limited convention support not documented

The README only mentions pascalCase and upperCaseFirst, but doesn't state that other conventions are unsupported. Users who try camelCase or snakeCase will silently get incorrect behavior. Please document the supported values explicitly.

5. Edge cases in to_pascal_case not covered by tests

The function handles these correctly on inspection, but tests would make this more robust:

• Empty string: "" → ""
• Single character: "A" → "A"
• Leading/trailing non-alphanumeric: "_SomeQuery_" → "SomeQuery"
• All uppercase: "ALLCAPS" → "Allcaps" (is this the desired behavior?)
• Numbers: "Query123Name" — digits are treated as alphanumeric, no boundary between digits and adjacent letters

6. Minor: unnecessary clone()

let import_name = apply_naming_convention(&operation_name, &self.options.naming_convention);
self.graphql_operations_or_fragments_to_import.push(import_name.clone());
let new_expr = Expr::Ident(quote_ident!(import_name).into());

The clone() is fine here, but you could push after constructing new_expr to avoid it, or use import_name.as_str() for the ident and push the original.

Summary

The core fix is correct and needed. The main action items before merging:

1. Add a changeset (and consider whether this is minor/breaking rather than patch)
2. Handle or document unsupported naming conventions
3. Update the README to list supported namingConvention values explicitly

Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 332e70f974

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Handle non-pascal namingConvention values instead of forcing PascalCase

apply_naming_convention only recognizes change-case-all#upperCaseFirst; every other string falls through to to_pascal_case. GraphQL Code Generator also accepts values like keep, change-case-all#lowerCase, lodash#camelCase, or a custom module path, so projects that mirror one of those valid configs into this plugin will still import PascalCased symbols. For example, with namingConvention: "keep", an operation like SomeEGRockets should stay SomeEGRocketsDocument, but this transform rewrites it to SomeEgRocketsDocument, which no longer matches the generated export.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Accept object-form namingConvention configs

PluginOptions now deserializes namingConvention as a plain String, but valid Codegen configs also use the object form (for example to set enumValues separately or enable transformUnderscore). If a project follows the new README guidance and passes that same config into the SWC plugin, serde_json::from_str(...).expect(...) in process_transform will reject the object and abort the transform before compilation starts.

Useful? React with 👍 / 👎.