Skip to content

fix(es/minifier): Remove unnecessary check when invoke IIFE#10257

Merged
kdy1 merged 1 commit intoswc-project:mainfrom
Austaras:remove
Mar 24, 2025
Merged

fix(es/minifier): Remove unnecessary check when invoke IIFE#10257
kdy1 merged 1 commit intoswc-project:mainfrom
Austaras:remove

Conversation

@Austaras
Copy link
Member

@Austaras Austaras commented Mar 23, 2025

Description:

The original code explicitly disables invoking IIFE if there's a param's method is called. However I don't think we need that check.

Related issue:

@Austaras Austaras requested a review from a team as a code owner March 23, 2025 15:45
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2025

⚠️ No Changeset found

Latest commit: e6f8c80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Mar 23, 2025
@kdy1 kdy1 self-assigned this Mar 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025

CodSpeed Performance Report

Merging #10257 will degrade performances by 1.58%

Comparing Austaras:remove (e6f8c80) with main (9c9b0ba)

Summary

❌ 1 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/terser 29.1 ms 29.6 ms -1.58%

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this after waiting for the current publish action 👍
Thank you for the digging! I may need to add comments to more places.

@kdy1 kdy1 merged commit 6b75775 into swc-project:main Mar 24, 2025
169 checks passed
@Austaras Austaras deleted the remove branch March 24, 2025 07:18
@kdy1 kdy1 modified the milestones: Planned, v1.11.14 Mar 31, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

es/minifier: inline IIFE edge case with callexpr on memberexpr

2 participants