fix(es/minifier): Remove unnecessary check when invoke IIFE#10257
Merged
kdy1 merged 1 commit intoswc-project:mainfrom Mar 24, 2025
Merged
fix(es/minifier): Remove unnecessary check when invoke IIFE#10257kdy1 merged 1 commit intoswc-project:mainfrom
kdy1 merged 1 commit intoswc-project:mainfrom
Conversation
|
kdy1
reviewed
Mar 24, 2025
CodSpeed Performance ReportMerging #10257 will degrade performances by 1.58%Comparing Summary
Benchmarks breakdown
|
kdy1
approved these changes
Mar 24, 2025
Member
kdy1
left a comment
There was a problem hiding this comment.
I'll merge this after waiting for the current publish action 👍
Thank you for the digging! I may need to add comments to more places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The original code explicitly disables invoking IIFE if there's a param's method is called. However I don't think we need that check.
Related issue:
es/minifier: inline IIFE edge case with callexpr on memberexpr #10255