perf(es/parser): Defne Token as TokenType + TokenValue
#10397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
OK, I understand the meaning of this change. I will create a new PR to implement it. |
bvanjoi
reviewed
Apr 21, 2025
| pub kind: TokenType, | ||
| pub span: Span, | ||
| /// Had a line break before this token? | ||
| pub had_line_break: bool, |
Contributor
There was a problem hiding this comment.
had_line_break also can move into Parser::state, see: https://github.com/microsoft/TypeScript/blob/main/src/compiler/scanner.ts#L1071
Member
Author
|
Closing in favor of #10399 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I expect this to improve the performance of the parser greatly.
cc @bvanjoi
Can you help with this task?