feat(es/minifier): Regex support for format.comments

[CPunisher]

Description:

Use regress because it is compatible with EcmaScript Syntax. So the users can easily migrate from terser.

I will also update the docs.

Related issue (if exists):

closes: #9674

[kdy1]

We are supporting regex in some places with rust syntax, so I'm not sure if it's fine to mix regex. Should we adjust CachedRegex to have two variants like { regex: "rust regex" } | { jsRegex: "js regex" }? I'm not sure about the naming, though.

[kdy1]

At the time of introducing regex to SWC config for the first, there was no good ECMAScript regex crate...
I think we need to do SWC v2 soon, if possible, to clean up APIs, though.

[CPunisher]

Should we adjust CachedRegex

CachedRegex is serialized into strings or is deserialized from strings. To keep the compatibility, if we rewrite it to a enum, we may still serialize the RustRegex variant to a string and serialize the JsRegex to something like { regex: string }.

However, after checking the codebase, it seems that most CachedRegexs are not user-defined but we directly use them in rust. One exception is preserve_comments in html minifier.

🤔 So I'm not sure whether it's necessary to adjust CachedRegex.

[kdy1]

Oh. Then let’s just use js regex, but with something like CachedJsRegex (if the js regex crate supports compiling regex)

[changeset-bot]

⚠️ No Changeset found

Latest commit: a06f5ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #10571 will not alter performance

_{Comparing CPunisher:06-04-feat/preserve-comments-regex (a06f5ad) with main (e6d4da2)}

Summary

✅ 144 untouched benchmarks

[kdy1]

Thank you!