Add mention of the file browser opened by jupyter notebook#396
Closed
djhoese wants to merge 1 commit intoswcarpentry:gh-pagesfrom
Closed
Add mention of the file browser opened by jupyter notebook#396djhoese wants to merge 1 commit intoswcarpentry:gh-pagesfrom
djhoese wants to merge 1 commit intoswcarpentry:gh-pagesfrom
Conversation
alee
approved these changes
May 21, 2019
Member
alee
left a comment
alee
left a comment
There was a problem hiding this comment.
LGTM, adding a screenshot would be great too - how about the example data files from the lesson? it would include some local filesystem specific paths but that's probably ok..
Member
|
Note that the changes here may be subsumed by #398 now - would you like to fit these changes into that larger PR? |
Member
|
Closing for now as this has been mostly addressed in #398 and the accompanying JupyterLab UI changes. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #395.
As mentioned in #395 there is currently no mention of the file browser that is first shown in the browser window when starting the Jupyter Notebook server with
jupyter notebook. A coworker was confused at why their screen (the file browser) was not the same as the screenshot shown.I could see a better solution being a screenshot of the file browser before the current screenshot, but I'm not sure what files should be shown in the screenshot or if there are any preferred ways of making screenshots for lessons.
Feel free to ask me to change the language/tone of what I've changed. Thoughts?