feat: remote screen brightness control from sender#68
Closed
ThomasWaldmann wants to merge 1 commit into
Closed
Conversation
DrDavidL
added a commit
to DrDavidL/targetBridge
that referenced
this pull request
Jun 3, 2026
PR swellweb#68 (remote brightness control) already claims packet type 0x33, and it predates this branch. Cede 0x33 to brightness and shift the KVM input types up one: inputControl 0x33→0x34, mouseMove→0x35, mouseButton→0x36, scroll→0x37, key→0x38. Updated in lockstep in TBMonitorProtocol.swift and the receiver's proto.h (both reference these by name, so only the wire values change). Now swellweb#68 and this PR can merge in any order without a packet-type clash. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
|
Thanks again for this contribution. Remote brightness control is included in the 3.0 release branch and is part of the new release PR to main. Really appreciate the work on this. |
Contributor
Author
|
@swellweb If you have all you need from here, feel free to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for controlling the target receiver's screen brightness directly from the sender app.
Key Changes
0x33(TB_PKT_BRIGHTNESS/.brightness) to transmit brightness levels.DisplayServicesframework at runtime viadlopento control active screens' brightness smoothly.