bjwealthy submitting his assignment 2 #2

bjwealthy · 2017-06-05T16:50:40Z

No description provided.

abeprosper

Did you change your username? I don't seem to find your first assignment submission. Here is the link to your grade:

https://docs.google.com/document/d/1zkQ5kGRDBuugJdeWpLWsLurwbqUPi2k7XYIdHQ4TQ84/edit

abeprosper · 2017-06-24T12:22:58Z

FindRange.java

+ */
+
+import acm.program.*;
+


This program does not work. I think you mis understood the question.

i will work on it again, thanks

abeprosper · 2017-06-24T12:23:17Z

FindRange.java

+		int n1 =  readInt("First value: ");
+
+		if(n1==0){
+			println("No you cant enter s3ntinel first");


Also what's with the 3 in place of e? s3ntinel?

abeprosper · 2017-06-24T12:27:12Z

Hailstone.java

+ * This file is the starter file for the Hailstone problem.
+ */
+
+import acm.program.*;


Your program does not print how many steps it takes to reach to value 1.

abeprosper · 2017-06-24T12:29:54Z

ProgramHierarchy.java

+ * This file is the starter file for the ProgramHierarchy problem.
+ */
+
+import acm.graphics.*;


Generally you should avoid the use of constant numbers in your program. You have values like (130, 175, 210...etc) throughout your code and this is not a good idea because:

Someone reading your code will be confused how you came up with them

If requirements change your program will be really hard to update. For example imagine for this exercise the requirements changed and we decide that the value for HEIGHT (50) and WIDTH (150) should be changed to HEIGHT = 60 and WIDTH = 180

If this happens your program will fail to draw the right diagram. To make it work you will have to go back and start changing all the numbers throughout your program. It should be possible to come up with a solution that works without you doing further modification. The ability of a program to be able to adapt to changes like that is called scalability. So in this case your solution is not scalable enough.

abeprosper · 2017-06-24T12:40:28Z

ProgramHierarchy.java

+    private static final int HEIGHT = 50;
+    private static final int WIDTH = 150;
+
+    public void run() {


You should breakdown your program into smaller understandable methods. So the run method should have looked like this

public void run() { drawProgramBox(); drawConsoleLine(); drawConsoleBox(); drawGraphicsLine(); drawGraphicsBox(); drawDialogLine(); drawDialogBox(); }

abeprosper · 2017-06-24T12:44:47Z

Pyramid.java

+ * to change accordingly.
+ */
+
+import acm.graphics.*;


I suppose you didn't have enough time to code this. :(

abeprosper · 2017-06-24T12:46:00Z

PythagoreanTheorem.java

+
+	double c = Math.sqrt((a*a) + (b*b));
+
+	println("The ansa is " +c);


"The answer " instead of "The ansa"

abeprosper · 2017-06-24T12:48:26Z

Target.java

+ * This file is the starter file for the Target problem.
+ */
+
+import acm.graphics.*;


The solution does not draw the target correctly as described in the assignment.

abeprosper · 2017-06-24T12:49:03Z

Target.java

+import java.awt.*;
+
+public class Target extends GraphicsProgram {	
+	public void run() {


The radius and pixel values should have been constants similar to what the starter code for the pyramid question had brick width, brick height and number of bricks on the base as constants. So you should have had something like this:

private static final int PIXELS_PER_INCH = 72; private static final double RADIUS_OUTER_CIRCLE = 1.0; private static final double RADIUS_WHITE_CIRCLE = 0.65; private static final double RADIUS_INNER_CIRCLE = 0.3;

Also again this solution is not scalable (If the assignment requirements changed to have different radiuses your program will not work) and I don't think it uses the right measurements provided by the question (specifically the radiuses: 1.0, 0.65 and 0.3)

bjwealthy

Good day Mr Abraham. I hope your day is going on fine. Thanks for the review of the assignments.

I found out that you have not been seeing my assignments because i have not been doing a PULL REQUEST. I was just informed by a colleague and I did just that now.

I will be grateful if, amidst your busy schedule, you can help me find time and review them.

Thanks.

bjwealthy · 2017-06-28T18:12:31Z

FindRange.java

+ */
+
+import acm.program.*;
+


i will work on it again, thanks

S added 30 commits June 2, 2017 17:41

{"types":"A","runs":4}

3bb1836

{"types":"C","runs":5}

359527c

{"types":"C","runs":0}

b2909a4

{"types":"C","runs":1}

a8022ea

{"types":"C","runs":2}

b85a4d3

{"types":"C","runs":31}

7ad7944

{"types":"C","runs":0}

41def3a

{"types":"C","runs":1}

36b2500

{"types":"C","runs":6}

016c179

{"types":"C","runs":1}

bc6b77c

{"types":"C","runs":4}

fdbafe1

{"types":"C","runs":6}

b80bb6e

{"types":"C","runs":7}

7249aa9

{"types":"C","runs":8}

0f14e37

{"types":"C","runs":9}

e4031d6

{"types":"C","runs":10}

366d5ee

{"types":"C","runs":12}

2f271ee

{"types":"C","runs":13}

f3ff050

{"types":"C","runs":14}

c11a998

{"types":"C","runs":15}

5ed397c

{"types":"C","runs":16}

b29934f

{"types":"C","runs":17}

108b15c

{"types":"C","runs":18}

750cb93

{"types":"C","runs":1}

d2e1a7b

{"types":"C","runs":2}

3e83e7c

{"types":"C","runs":3}

a050b0a

{"types":"C","runs":4}

fe86149

{"types":"C","runs":5}

4e9cb1c

{"types":"C","runs":6}

66e35b0

{"types":"C","runs":7}

405d864

S and others added 19 commits June 5, 2017 17:58

{"types":"C","runs":9}

d106b4e

{"types":"C","runs":10}

c79ce72

{"types":"C","runs":11}

177cfa3

{"types":"C","runs":12}

80441ad

{"types":"C","runs":13}

d07e65e

{"types":"C","runs":14}

c5340c3

{"types":"C","runs":15}

4de094b

{"types":"C","runs":16}

84459e6

{"types":"C","runs":17}

489c21c

{"types":"C","runs":18}

52bb186

{"types":"C","runs":19}

0a162e9

{"types":"C","runs":22}

3de4731

{"types":"C","runs":22}

9940c9e

submitting my assignment 2

84a5f04

{"types":"C","runs":0}

fb3643d

{"types":"C","runs":2}

b41d3ca

{"types":"C","runs":3}

690af48

{"types":"C","runs":24}

977f481

{"types":"C","runs":1}

08bcce3

abeprosper reviewed Jun 24, 2017

View reviewed changes

S and others added 9 commits June 28, 2017 19:18

{"types":"C","runs":1}

5cd2e4a

changes to range

8d29fb5

{"types":"R","runs":1}

764ea32

{"types":"A","runs":1}

75097b4

{"types":"R","runs":1}

f080472

{"types":"A","runs":1}

5eb94b2

{"types":"C","runs":46}

5a0c19b

{"types":"C","runs":1}

c4335f1

{"types":"C","runs":4}

7739428

bjwealthy commented Jul 26, 2017

View reviewed changes

FindRange.java Outdated

*/

import acm.program.*;

Copy link

Author

bjwealthy Jun 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will work on it again, thanks


		double c = Math.sqrt((aa) + (bb));

		println("The ansa is " +c);

bjwealthy submitting his assignment 2 #2

Are you sure you want to change the base?

bjwealthy submitting his assignment 2 #2

Uh oh!

Conversation

bjwealthy commented Jun 5, 2017

Uh oh!

abeprosper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjwealthy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants