Reject control frames with payload >125 bytes per RFC 6455 §5.5#214
Merged
swhitty merged 1 commit intoMay 16, 2026
Conversation
Control frames (ping/pong/close) MUST have payload length ≤ 125 bytes. Without this guard, a peer could send a 1 MB ping and have it echoed back verbatim as a pong by WSHandler.makeResponseFrames. Closes TVT-306 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
swhitty
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WSFrameValidatornow rejects ping/pong/close frames with payload > 125 bytes, throwingWSFrameValidator.Error.WSHandler.makeResponseFrames.beginContinuation; this PR fills the size-cap gap.Closes TVT-306.
Test plan
controlFrames_throwError_whenPayloadExceeds125Bytes— 126-byte ping/pong/close each throw.controlFrames_areAccepted_whenPayloadIsAtMost125Bytes— boundary (125 bytes) and empty payload pass through unchanged.controlFrames_ThrowError_WhenNotFinstill passes (fragmentation rejection is unchanged).swift test— 441 tests pass.swift build— clean, no warnings.🤖 Generated with Claude Code