Skip to content

Fix compiler errors from check third-party dependency on Windows #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Fix compiler errors from check third-party dependency on Windows #188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bcddf3
Prevent diagnostics from unmaintained check library
sbmueller Oct 15, 2025
32d5cd2
Argh
sbmueller Oct 15, 2025
8acdfb4
GGG
sbmueller Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions FindCheck.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,29 @@
include("GenericFindDependency")
option(CHECK_ENABLE_TESTS "" OFF)
option(CHECK_INSTALL "" OFF)

# Store current compile options to restore later
set(_SAVED_CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")

# Temporarily modify CMAKE_C_FLAGS to disable implicit-function-declaration errors
# for the check library compilation (needed for Windows compatibility)
if(WIN32)
if(MSVC)
# MSVC: Remove warnings-as-errors flag and disable specific warning C4013 (implicit function declaration)
string(REPLACE "/WX" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4013")
else()
# MinGW/GCC: Remove -Werror and disable implicit-function-declaration errors
string(REPLACE "-Werror" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-error=implicit-function-declaration")
endif()
endif()

GenericFindDependency(
TARGET check
SYSTEM_INCLUDES
)

# Restore original compile flags
set(CMAKE_C_FLAGS "${_SAVED_CMAKE_C_FLAGS}")
unset(_SAVED_CMAKE_C_FLAGS)