Default dependency feature options #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
force-pushed
the
woodfell/default_package_options
branch
from
1218fcc to
a343c20
Compare
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most packages provide options to enable or disable features such as unit tests, documentation, etc. Most of the time when we include a dependency as a submodule we want to disable all these optional features to avoid various cmake nastiness. The commands to disable features (eg.
option(libsbp_ENABLE_TESTS "" OFF)) occur almost everywhere that each package is used and rarely, if ever, vary. It would make sense to set some default options in theFind*.cmakemodules to disable features by default, leaving open the ability for a higher level project to selectively re-enable something if it really requires it.