Skip to content

Conversation

@yizow
Copy link
Contributor

@yizow yizow commented Oct 22, 2019

No description provided.

@yizow yizow changed the title add FindUbx.cmake add FindUbx.cmake [STAR-840] Oct 22, 2019
@yizow yizow requested review from jbangelo and scarcanague October 24, 2019 00:05
@jbangelo jbangelo requested a review from woodfell October 24, 2019 17:13
Copy link
Contributor

@jbangelo jbangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Adding Matt just to give a once over since he's been more directly involved with the CMake refactoring.

Copy link
Contributor

@woodfell woodfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants