Fix windows library install directory #1061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
see https://snav.slack.com/archives/CG9PUMGUX/p1627996673000900
Testing
Ran the installation on my Linux machine with MingGW cross compilation and got the following results (need to specify the
-D BUILD_SHARED_LIBS=trueoptions for cmake):Cherry picked the changes and ran on the ESD-2043-portability-project branch with VS2019 and got the following (firstly the
masterbranch currently doesn't compiler with VS2019, also I needed to disable the unit tests as the post build tests were failing to link togtest.dll):