Skip to content

Conversation

@woodfell
Copy link
Contributor

Import new clang-tidy module.

Remove .clang-tidy, it's now automatically generated by ClangTidy.cmake

Any additional changes needed by new common clang-tidy config

Copy link
Contributor

@samvrlewis samvrlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do our clang tidy rules not like 'str' and 'truncate' being in variable names?

@woodfell
Copy link
Contributor Author

Do our clang tidy rules not like 'str' and 'truncate' being in variable names?

No, it was complaining about different names in the function declaration and definition. I went with the policy of using buf for the "raw" function saving str for the non-raw functions, and trunc rather than truncate since it was more common

Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woodfell woodfell merged commit e3539d2 into master Sep 30, 2021
@woodfell woodfell deleted the woodfell/esd-2180/clang-tidy-2 branch September 30, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants