rust: support Result<Sbp> in with_rover_time #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriaga
commented
Oct 21, 2021
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| let msg = self.messages.next()?; | ||
| pub trait HasTime { |
Contributor
Author
There was a problem hiding this comment.
Kind of a clunky solution but I don't know a better way to do this without specialization
notoriaga
force-pushed
the
steve/rover-time
branch
from
ca9268e to
c550c1b
Compare
silverjam
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you had to convert the iterator returned by
iter_messagesfromIterator<Result<Sbp>>toIterator<Sbp>before callingwith_rover_time. Now it works on both kinds of iterators