[ESD-2250] Encode/decode functions in cpp message traits #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
requested review from
RReichert,
antrikshsrivastava,
jbangelo,
samvrlewis,
silverjam and
sokhealy
samvrlewis
approved these changes
Nov 2, 2021
silverjam
force-pushed
the
woodfell/esd-2250
branch
from
ded5d7f to
1f69397
Compare
antrikshsrivastava
approved these changes
Nov 2, 2021
+ Use `whitelist_externals` to be compatible with older tox versions + Pin sphinx deps to versions that work, the floating dependencies are currently producing a broken build
silverjam
force-pushed
the
woodfell/esd-2250
branch
from
1f69397 to
e7d88ad
Compare
silverjam
approved these changes
Nov 3, 2021
Contributor
silverjam
left a comment
silverjam
left a comment
There was a problem hiding this comment.
Done with CI fixes, let's wait for CI to pass before merging (it should pass, but would like to double check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it was originally thought that there wouldn't be a need to deal with encoded messages using the V4 API the ephemeris swiftlet work introduced a need with how it dumps the see after startup.
Add wrappers for the message type specific encode/decode/length functions to c++ message traits