Add signature and certificate messages [GV2-74] #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the initial version of the SBP signature and certificate messages as first proposed in https://swift-nav.atlassian.net/wiki/spaces/ENG/pages/2234843801/Secure+Corrections+Client+Interface+Design
samvrlewis
commented
Jun 27, 2022
Will help to associate cert messages with each other
silverjam
reviewed
Jun 29, 2022
silverjam
reviewed
Jun 29, 2022
silverjam
reviewed
Jun 29, 2022
silverjam
approved these changes
Jun 30, 2022
Contributor
|
Will need to add a test vector for the new messages before SonarCloud will pass. The json2test tool that @adrian-kong wrote will help with this. |
Contributor
|
@samvrlewis can we introduce stubs for these messages on master? |
Contributor
Author
Will do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the initial version of the SBP signature and certificate messages
as first proposed in https://swift-nav.atlassian.net/wiki/spaces/ENG/pages/2234843801/Secure+Corrections+Client+Interface+Design
API compatibility
Messages aren't 100% finalized yet, so shouldn't be promoted from staging yet. Having them here will allow for easier prototyping though.
JIRA Reference
https://swift-nav.atlassian.net/browse/GV2-74