Enforce Java 11 in build gradle #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test passed somehow, not needed anymore
silverjam
approved these changes
Jul 6, 2022
Contributor
|
What does this mean for consumers of the library, do they have to use java 11 or is this just for our ci? If the former could we do >= 11 or something? |
Contributor
Author
I believe it checks JDK version for 11, if no match will download that version. Should only affect locally for those building the src so using this as a dependency would be ok. |
notoriaga
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should resolve Jacoco issue where
gradle jacocoTestReportfails to run due to major version upgrade