Fix bazel build: stack-protector #1238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
The error in gnss-converters:
It is caused by the
-fstack-protectorflag, which Bazel c++ rules add by default. In the Bazel submodule update, we enabled-Werror, causing the libsbp build to fail.I removed the
-Wstack-protectorflag from libsbp.Tested here:
https://github.com/swift-nav/gnss-converters-private/pull/1366
https://jenkins.ci.swift-nav.com/blue/organizations/jenkins/swift-nav%2Fgnss-converters-private/detail/PR-1366/1/pipeline/25
API compatibility
Does this change introduce a API compatibility risk?
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference