Skip to content

Conversation

@krisukox
Copy link
Contributor

@krisukox krisukox commented Nov 9, 2022

Description

@swift-nav/devinfra
The error in gnss-converters:

external/libsbp/c/src/sbp.c: In function 'send_payload':
external/libsbp/c/src/sbp.c:580:11: error: stack protector not protecting function: all local arrays are less than 8 bytes long [-Werror=stack-protector]
  580 | static s8 send_payload(sbp_state_t *s, sbp_msg_type_t msg_type, u16 sender_id, u8 len, u8 *payload,
      |           ^~~~~~~~~~~~
cc1: all warnings being treated as errors

It is caused by the -fstack-protector flag, which Bazel c++ rules add by default. In the Bazel submodule update, we enabled -Werror, causing the libsbp build to fail.
I removed the -Wstack-protector flag from libsbp.

Tested here:
https://github.com/swift-nav/gnss-converters-private/pull/1366
https://jenkins.ci.swift-nav.com/blue/organizations/jenkins/swift-nav%2Fgnss-converters-private/detail/PR-1366/1/pipeline/25

API compatibility

Does this change introduce a API compatibility risk?

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

@krisukox krisukox requested review from a team and silverjam as code owners November 9, 2022 08:26
@krisukox krisukox requested a review from jungleraptor November 9, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants