Add message name to sbp2json output [DEVINFRA-1019] #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverjam
approved these changes
Nov 21, 2022
Contributor
Yeah, it'll just be ignored |
Contributor
Author
|
@silverjam do you know why the |
silverjam
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
In the JSON output of
sbp2json, a new fieldmsg_nameis added which gives the SBP message name. This improves the readability of the output by avoiding the need to grep for message numbers.API compatibility
I don't think this will break the API as it adds a new field, and the field should be ignored when reading the output with older version of
json2sbp.@silverjam is this correct?
API compatibility plan
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/DEVINFRA-1019