Skip to content

Conversation

@JADC362
Copy link
Contributor

@JADC362 JADC362 commented Jan 16, 2023

Description

@swift-nav/devinfra

Add a MsgSsrGriddedCorrectionBounds msg (SBP-1534) test, that checks if an empty STEC list can be encoded / decoded.

Task PC-313

API compatibility

It doesn't add compatibility risk. It increases the coverage for a test case.

@JADC362 JADC362 requested review from a team, notoriaga and silverjam as code owners January 16, 2023 15:31
@JADC362 JADC362 requested a review from jtec January 16, 2023 15:32
tow: 180
wn: 3
num_msgs: 1
seq_num: 1
Copy link
Contributor

@jtec jtec Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sequence number might be zero-based, at least it's what I'm getting when encoding an SsrAtmo message with a single grid point into SBP in https://github.com/swift-nav/sip/:
Screenshot from 2023-01-18 15-51-04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm are you sure? I set this field to 1, since the first (original) CorrectionBounds test has 1. I look the SBP documentation and it's not clear if the seq_num starts from 0 or 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ask to Ekumen team, so I will just leave here @fpezzinosn answer: "for testing it was better to use a number different from zero since it would be hard to tell if it was encoded properly or if it failed".

If you prefer I can change to 0. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants