make it so all .rs files are treated as text files for git diffs #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
This is a minor quality of life improvement for libsbp. It simply makes it so that all
*.rsfiles are treated as text when sent to git diff... even those with unprintable characters.Some of the autogen'd code in this library's history includes non-printable null characters and those rust files would be treated as binary by git diff prior to this PR.
Risks
There is a chance that by doing this, someone could add a non-printable characters to a
*.rsfile that wouldn't show up in thegit diffrendered by github. I do believe it will show up as changed line though.