-
Notifications
You must be signed in to change notification settings - Fork 97
signing: add new ECDSA based signature messages #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds new messages: - ECDSA signature message - ECDSA certificate message for IC and CC - New "certificate chain" message (i.e. allow list) Jiras: - https://swift-nav.atlassian.net/browse/GV2-191 - https://swift-nav.atlassian.net/browse/GV2-192 - https://swift-nav.atlassian.net/browse/GV2-193
|
Most of the pertinent changes are here: https://github.com/swift-nav/libsbp/pull/1302/files#diff-0daef5fdde7e96323ae084523dcf809462bda38b3960216da50007f9cf805c7f |
|
@silverjam Do we have to deprecate the ED25519 messages? I was talking with RK that in some time (not so sure future) we might want to support having different algorithms. I was wondering if it was better to skip deprecating them for now or to just deprecating them and adding them again if we ever decide to go that way. |
I think we should deprecate for now since we're already changing the format of the signature messages (in the |
|
Merging, only failure is a transient benchmark failure |
Description
Adds new messages:
@swift-nav/devinfra
API compatibility
Does this change introduce a API compatibility risk?
No, just adds some new messages and deprecates some existing ones.
JIRA Reference