Skip to content

Conversation

@silverjam
Copy link
Contributor

Description

Adds new messages:

  • ECDSA signature message
  • ECDSA certificate message for IC and CC
  • New "certificate chain" message (i.e. allow list)

@swift-nav/devinfra

API compatibility

Does this change introduce a API compatibility risk?

No, just adds some new messages and deprecates some existing ones.

JIRA Reference

Adds new messages:
- ECDSA signature message
- ECDSA certificate message for IC and CC
- New "certificate chain" message (i.e. allow list)

Jiras:
- https://swift-nav.atlassian.net/browse/GV2-191
- https://swift-nav.atlassian.net/browse/GV2-192
- https://swift-nav.atlassian.net/browse/GV2-193
@silverjam silverjam requested review from a team and notoriaga as code owners March 2, 2023 04:44
@silverjam silverjam requested review from Blast545 and RReichert March 2, 2023 04:44
@silverjam silverjam requested review from Jason-Swift and removed request for swiftnav-adam March 2, 2023 04:44
@silverjam
Copy link
Contributor Author

@Blast545
Copy link

Blast545 commented Mar 2, 2023

@silverjam Do we have to deprecate the ED25519 messages? I was talking with RK that in some time (not so sure future) we might want to support having different algorithms.

I was wondering if it was better to skip deprecating them for now or to just deprecating them and adding them again if we ever decide to go that way.

@silverjam
Copy link
Contributor Author

@silverjam Do we have to deprecate the ED25519 messages? I was talking with RK that in some time (not so sure future) we might want to support having different algorithms.

I think we should deprecate for now since we're already changing the format of the signature messages (in the certificate_id for example).

@silverjam
Copy link
Contributor Author

Merging, only failure is a transient benchmark failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants