fix signature in MsgCertificateChain [GV2-193] #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverjam
reviewed
Mar 17, 2023
silverjam
reviewed
Mar 17, 2023
| - ECDSASignature: | ||
| short_desc: ECDSA signature | ||
| fields: | ||
| - len: |
Contributor
There was a problem hiding this comment.
I think if we move len field to after data then we technically would not need to rev MSG_ECDSA_SIGNATURE since the wire format/order/length of the bytes would be the same, but not sure that the message checker in CI would be able to handle that.
Contributor
|
FWIW I think revving the messages is fine to fix this, I think once all of these E.g. |
Co-authored-by: Jason Mobarak <jason@swift-nav.com>
silverjam
approved these changes
Mar 17, 2023
Blast545
pushed a commit
that referenced
this pull request
Apr 26, 2023
Co-authored-by: Jason Mobarak <jason@swift-nav.com>
lkloh
pushed a commit
that referenced
this pull request
Apr 27, 2023
* update MSG_ACKNOWLEDGE on demand fields (#1303) * variable length ecdsa signature [GV2-193] (#1306) * Add signature length field to MsgEcdsaSignature Co-authored-by: Jason Mobarak <jason@swift-nav.com> * fix signature in MsgCertificateChain [GV2-193] (#1307) Co-authored-by: Jason Mobarak <jason@swift-nav.com> * benchmark: run on consistent machine type Benchmarks seem to oscilate between two values, so attempt to compensate for this by pinning the machine type that things are run on. * python: add framer msg type filter (#1321) * python: add msg type filter To help with speed issues around Python object construction, add an easy means of avoiding work in the Python API. * Update python/sbp/client/framer.py Co-authored-by: Patrick Crumley <patrick.crumley@gmail.com> * docker: use buster, stretch is archived * python: add unit test for framer filter * python: add unit test for framer message filter --------- Co-authored-by: Patrick Crumley <patrick.crumley@gmail.com> --------- Co-authored-by: Steven Meyer <smeyer@fastmail.com> Co-authored-by: Jason Mobarak <jason@swift-nav.com> Co-authored-by: Patrick Crumley <patrick.crumley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Fixes the signature field of MsgCertificateChain. Also makes a separate type for the signature because we use in it multiple places
API compatibility
Does this change introduce a API compatibility risk?
New messages were made for MsgCertificateChain and MsgEcdsaSignature