Skip to content

Conversation

@RReichert
Copy link
Contributor

Description

Using the latest GCC compiler, you get the following error when building tests:

external/googletest/googletest/src/gtest-death-test.cc: In function 'bool testing::internal::StackGrowsDown()':                                                                                                                               
external/googletest/googletest/src/gtest-death-test.cc:1301:24: warning: 'dummy' may be used uninitialized [-Wmaybe-uninitialized]                                                                                                            
 1301 |   StackLowerThanAddress(&dummy, &result);                                                                                                                                                                                             
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~                                                                                                                                                                                              
external/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type 'const void*' to 'void testing::internal::StackLowerThanAddress(const void*, bool*)' declared here                                                
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {                                                                                                                                                                    
      |             ^~~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                                     
external/googletest/googletest/src/gtest-death-test.cc:1299:7: note: 'dummy' declared here                                                                                                                                                    
 1299 |   int dummy;                                                                                                                                                                                                                          
      |       ^~~~~                   

The upgrade aligns with the version of our other repositories.

API compatibility

No

API compatibility plan

NA

JIRA Reference

None

@RReichert RReichert requested review from a team and silverjam as code owners March 23, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants