[WIP] Add JIT for crc, build into existing buffer to avoid copies #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the behavior of Framer to stop when "iterator" (the remote connection or file) is no longer producing data. This seems to be a more standard behavior and it allows us to create an sbp2json utility that will stop when no more data is available. We can potentially drop these changes if we can't easily figure out how to harmonize this with the rest of the code base.
Framer now use an "into_buffer" function to avoid copying data
Use numba to accellerate the crc function, running this shows the following speed-ups (first number is with JIT, second is without):
TODO:
Need to abstract
build_payloadand the creation of theStreamPayloadobject, currently there's a lot of unnecessary duplicated code between generated objects.Remove http support and fix unit tests. HTTP related tests are currently failing and I suspect many of the unit tests need to updated to account for the new behavior of the Framer iterator.