Skip to content

Close serial port fd when piksi disconnects [ESD-1111] #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Close serial port fd when piksi disconnects [ESD-1111] #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eda198
Close serial port fd when piksi disconnects
Mar 4, 2019
f589875
Use hostname instead of IP address
Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/sbp/client/drivers/pyserial_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def read(self, size):
print()
print("Piksi disconnected")
print()
self.handle.close()
raise IOError

def write(self, s):
Expand All @@ -103,6 +104,7 @@ def write(self, s):
print()
print("Piksi disconnected")
print()
self.handle.close()
raise IOError

def __enter__(self):
Expand Down
2 changes: 1 addition & 1 deletion python/tests/sbp/client/test_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class MockServer(socketserver.ThreadingMixIn, socketserver.TCPServer):
pass

def tcp_server(handler):
server = MockServer(("127.0.0.1", 0), handler)
server = MockServer(("localhost", 0), handler)
ip, port = server.server_address
server_thread = threading.Thread(target=server.serve_forever)
server_thread.daemon = True
Expand Down