Add option to omit metadata [ESD-1170] #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmiettinen
changed the title
pmiettinen
requested review from
benjaminaltieri,
denniszollo,
silverjam and
tn-exafore
silverjam
approved these changes
Mar 14, 2019
Contributor
|
Looks good, but as far as I'm concerned without the metadata we should just be recording straight binary, not json. |
pmiettinen
force-pushed
the
pmiettinen/esd-1170-omit-metadata
branch
from
c3bd189 to
ae8671d
Compare
tn-exafore
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-nav/piksi_tools#989