Add option for explicit start [ESD-1166] #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverjam
reviewed
Mar 18, 2019
python/sbp/client/handler.py
Outdated
| ---------- | ||
| source : Iterable of tuple(SBP message, {'time':'ISO 8601 str'}) | ||
| Stream of SBP messages | ||
| explicit_start : Boolean |
Contributor
There was a problem hiding this comment.
Maybe autostart and default to true?
Contributor
Author
There was a problem hiding this comment.
Sure, sounds better.
pmiettinen
force-pushed
the
pmiettinen/esd-1166-delayed-start
branch
from
08c85cf to
987ef16
Compare
pmiettinen
force-pushed
the
pmiettinen/esd-1166-delayed-start
branch
from
987ef16 to
3fce418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If receive thread is started before all the callbacks are added and sink is ready it is highly probable that some of the messages at start are lost.