Skip to content

Add option for explicit start [ESD-1166] #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Add option for explicit start [ESD-1166] #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions python/sbp/client/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,15 @@ class Handler(object):
----------
source : Iterable of tuple(SBP message, {'time':'ISO 8601 str'})
Stream of SBP messages
autostart : Boolean
If false, start() shall be skipped when entering context scope and it
should be explicitly called by the parent. This will prevent losing
messages in case where receive thread would otherwise be started before
consumers are ready.
"""

def __init__(self, source):
def __init__(self, source, autostart=True):
self._autostart = autostart
self._source = source
self._callbacks = collections.defaultdict(set)
self._receive_thread = threading.Thread(
Expand All @@ -58,7 +64,8 @@ def _recv_thread(self):
self._dead = True

def __enter__(self):
self.start()
if self._autostart:
self.start()
return self

def __exit__(self, *args):
Expand Down
3 changes: 2 additions & 1 deletion python/tests/sbp/client/test_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ def assert_logger(s, **metadata):
assert s.payload==b'abc'
assert s.crc==0xDAEE
with PySerialDriver(port, baud) as driver:
with Handler(Framer(driver.read, None, verbose=False)) as link:
with Handler(Framer(driver.read, None, verbose=False), autostart=False) as link:
link.add_callback(assert_logger)
link.start()
while True:
if time.time() - t0 > timeout or cb_context['assert_logger_called']:
break
Expand Down