Skip to content

Conversation

@nsirola
Copy link
Contributor

@nsirola nsirola commented Mar 26, 2019

Add a new message to enable NMEA GSV sentence generation from SBP data.

image

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would appreciate an update to the range of expected values

@nsirola nsirola force-pushed the nsirola/EX-569_az_el_message branch from 4370ae9 to 58ce0be Compare March 29, 2019 09:28
@nsirola nsirola force-pushed the nsirola/EX-569_az_el_message branch from 1c59b1a to dc99cc6 Compare March 29, 2019 12:38
@nsirola
Copy link
Contributor Author

nsirola commented Mar 29, 2019

Rebased the yaml and unit test changes into one commit and all the generated files into another. Ready to merge.

@anth-cole
Copy link
Contributor

lgtm

@nsirola nsirola merged commit ee4bbe6 into master Mar 29, 2019
@nsirola nsirola deleted the nsirola/EX-569_az_el_message branch March 29, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants