Integrate numba into setuptools [ESD-1156] #687

pmiettinen · 2019-05-14T12:24:09Z

https://swift-nav.atlassian.net/projects/ESD/issues/ESD-1156

pmiettinen · 2019-05-15T12:09:19Z

CFFI initial concept OK.

Numba CC compiler getting stuck in pytest context. Investigating.

pmiettinen · 2019-05-15T12:20:29Z

pasi@pasi-linux:~/swiftnav/libsbp/python$ py.test -v tests/ -s
======================================================================================================== test session starts ========================================================================================================
platform linux2 -- Python 2.7.12, pytest-4.5.0, py-1.7.0, pluggy-0.9.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /mnt/users/pasi/swiftnav/libsbp/python, inifile: pytest.ini
plugins: xdist-1.26.1, forked-1.0.2, cov-2.5.1
collecting ... cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
generating LLVM code for 'parse_jit' into /tmp/pycc-build-parse_jit-_CyTzb/parse_jit.o
C compiler: x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC

creating /tmp/pycc-build-parse_jit-_CyTzb/mnt
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local/lib
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local/lib/python2.7
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local/lib/python2.7/site-packages
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local/lib/python2.7/site-packages/numba
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc
creating /tmp/pycc-build-parse_jit-_CyTzb/mnt/users/pasi/.local/lib/python2.7/site-packages/numba/runtime
compile options: '-DPYCC_MODULE_NAME=parse_jit -DPYCC_USE_NRT=1 -I/usr/include/python2.7 -I/usr/local/lib/python2.7/dist-packages/numpy/core/include -c'
x86_64-linux-gnu-gcc: /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/../runtime/nrt.c
x86_64-linux-gnu-gcc: /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/modulemixin.c
**HANG**

pmiettinen · 2019-05-15T12:37:45Z

Not reproducible in standalone compilation, only one unrelated warning:

pasi@pasi-linux:~/tmp$ x86_64-linux-gnu-gcc -DPYCC_MODULE_NAME=parse_jit -DPYCC_USE_NRT=1 -I/usr/include/python2.7 -I/usr/local/lib/python2.7/dist-packages/numpy/core/include -c /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/modulemixin.c
In file included from /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/modulemixin.c:16:0:
/mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/../_helperlib.c: In function ‘import_cython_function’:
/mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/../_helperlib.c:578:42: warning: passing argument 2 of ‘PyMapping_GetItemString’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     cobj = PyMapping_GetItemString(capi, function_name);
                                          ^
In file included from /usr/include/python2.7/Python.h:133:0,
                 from /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/../_pymodule.h:6,
                 from /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/modulemixin.c:8:
/usr/include/python2.7/abstract.h:1356:29: note: expected ‘char *’ but argument is of type ‘const char *’
      PyAPI_FUNC(PyObject *) PyMapping_GetItemString(PyObject *o, char *key);

pmiettinen · 2019-05-15T13:03:18Z

Seems to be somehow related to Python version.

python -c "from sbp.jit import msg" reproduces the issue with 2.7 which uses x86_64-linux-gnu-gcc for compiling.

On 3.5.0 build does not hang and it uses gcc.

pmiettinen · 2019-05-16T05:47:35Z

numba.pycc issue with py27 replicates with the example code from https://numba.pydata.org/numba-doc/dev/user/pycc.html

pmiettinen · 2019-05-16T06:09:49Z

Replicates on OSX with clang compiler so it's not about the compiler.

pmiettinen · 2019-05-16T07:14:39Z

To record the current status:

pycc.py standalone example

from numba.pycc import CC

cc = CC('my_module')
# Uncomment the following line to print out the compilation steps
cc.verbose = True

@cc.export('multf', 'f8(f8, f8)')
@cc.export('multi', 'i4(i4, i4)')
def mult(a, b):
    return a * b

@cc.export('square', 'f8(f8)')
def square(a):
    return a ** 2

cc.compile()

py35 success

pasi@pasi-linux:~/tmp$ python -c "import pycc"
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
generating LLVM code for 'my_module' into /tmp/pycc-build-my_module-nu_7foug/my_module.cpython-35m-x86_64-linux-gnu.o
C compiler: gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC

creating /tmp/pycc-build-my_module-nu_7foug/mnt
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages/numba
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages/numba/pycc
creating /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages/numba/runtime
compile options: '-DPYCC_MODULE_NAME=my_module -DPYCC_USE_NRT=1 -I/mnt/users/pasi/.pyenv/versions/3.5.0/include/python3.5m -I/mnt/users/pasi/.local/lib/python3.5/site-packages/numpy/core/include -c'
gcc: /mnt/users/pasi/.local/lib/python3.5/site-packages/numba/pycc/../_math_c99.c
gcc: /mnt/users/pasi/.local/lib/python3.5/site-packages/numba/pycc/modulemixin.c
gcc: /mnt/users/pasi/.local/lib/python3.5/site-packages/numba/pycc/../runtime/nrt.c
gcc -pthread -shared -L/mnt/users/pasi/.pyenv/versions/3.5.0/lib /tmp/pycc-build-my_module-nu_7foug/my_module.cpython-35m-x86_64-linux-gnu.o /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages/numba/pycc/modulemixin.o /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages/numba/_math_c99.o /tmp/pycc-build-my_module-nu_7foug/mnt/users/pasi/.local/lib/python3.5/site-packages/numba/runtime/nrt.o -L/mnt/users/pasi/.local/lib/python3.5/site-packages/numpy/core/lib -lnpymath -lm -o /mnt/users/pasi/tmp/my_module.cpython-35m-x86_64-linux-gnu.so

py27 hangs

pasi@pasi-linux:~/tmp$ python -c "import pycc"
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
generating LLVM code for 'my_module' into /tmp/pycc-build-my_module-Qq8jC8/my_module.o
C compiler: x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC

creating /tmp/pycc-build-my_module-Qq8jC8/mnt
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local/lib
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local/lib/python2.7
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local/lib/python2.7/site-packages
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local/lib/python2.7/site-packages/numba
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc
creating /tmp/pycc-build-my_module-Qq8jC8/mnt/users/pasi/.local/lib/python2.7/site-packages/numba/runtime
compile options: '-DPYCC_MODULE_NAME=my_module -DPYCC_USE_NRT=1 -I/usr/include/python2.7 -I/mnt/users/pasi/.local/lib/python2.7/site-packages/numpy/core/include -c'
x86_64-linux-gnu-gcc: /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/../_math_c99.c
x86_64-linux-gnu-gcc: /mnt/users/pasi/.local/lib/python2.7/site-packages/numba/pycc/../runtime/nrt.c

After narrowing down the scope with added debug prints in numba.pycc files, hanging seems to happen inside distutils.ccompiler.

pmiettinen · 2019-05-16T08:31:47Z

Appears that build uses numpy.distutils.ccompiler and the part of the code that hangs:

    if len(build) > 1 and jobs > 1:
        # build parallel
        import multiprocessing.pool
        pool = multiprocessing.pool.ThreadPool(jobs)
        pool.map(single_compile, build_items)
        pool.close()

Code is identical in both py27 and py35 numpy installations.

After forcing serial build, build doesn't hang.

pmiettinen · 2019-05-16T08:57:34Z

Narrowed down to subprocess.check_output(cmd) hanging in numpy.distutils.ccompiler when doing parallel build.

pmiettinen · 2019-05-16T11:12:16Z

Monkeypatching to serial build only helps. Needs to be investigated how rugged solution this is.

from numba.pycc import CC

from distutils.ccompiler import CCompiler
from numpy.distutils.misc_util import get_num_build_jobs
from numpy.distutils.ccompiler import _global_lock, _job_semaphore, _processing_files
from numpy.distutils import log

import sys
import types

def replace_method(klass, method_name, func):
    if sys.version_info[0] < 3:
        m = types.MethodType(func, None, klass)
        setattr(klass, method_name, m)

def CCompiler_compile(self, sources, output_dir=None, macros=None,
                      include_dirs=None, debug=0, extra_preargs=None,
                      extra_postargs=None, depends=None):
    """
    Compile one or more source files.

    Please refer to the Python distutils API reference for more details.

    Parameters
    ----------
    sources : list of str
        A list of filenames
    output_dir : str, optional
        Path to the output directory.
    macros : list of tuples
        A list of macro definitions.
    include_dirs : list of str, optional
        The directories to add to the default include file search path for
        this compilation only.
    debug : bool, optional
        Whether or not to output debug symbols in or alongside the object
        file(s).
    extra_preargs, extra_postargs : ?
        Extra pre- and post-arguments.
    depends : list of str, optional
        A list of file names that all targets depend on.

    Returns
    -------
    objects : list of str
        A list of object file names, one per source file `sources`.

    Raises
    ------
    CompileError
        If compilation fails.

    """
    # This method is effective only with Python >=2.3 distutils.
    # Any changes here should be applied also to fcompiler.compile
    # method to support pre Python 2.3 distutils.
    global _job_semaphore

    jobs = get_num_build_jobs()

    # setup semaphore to not exceed number of compile jobs when parallelized at
    # extension level (python >= 3.5)
    with _global_lock:
        if _job_semaphore is None:
            _job_semaphore = threading.Semaphore(jobs)

    if not sources:
        return []

    ccomp = self.compiler_so
    display = "C compiler: %s\n" % (' '.join(ccomp),)
    log.info(display)
    macros, objects, extra_postargs, pp_opts, build = \
            self._setup_compile(output_dir, macros, include_dirs, sources,
                                depends, extra_postargs)
    cc_args = self._get_cc_args(pp_opts, debug, extra_preargs)
    display = "compile options: '%s'" % (' '.join(cc_args))
    if extra_postargs:
        display += "\nextra options: '%s'" % (' '.join(extra_postargs))
    log.info(display)

    def single_compile(args):
        obj, (src, ext) = args

        # check if we are currently already processing the same object
        # happens when using the same source in multiple extensions
        while True:
            # need explicit lock as there is no atomic check and add with GIL
            with _global_lock:
                # file not being worked on, start working
                if obj not in _processing_files:
                    _processing_files.add(obj)
                    break
            # wait for the processing to end
            time.sleep(0.1)

        try:
            # retrieve slot from our #job semaphore and build
            with _job_semaphore:
                self._compile(obj, src, ext, cc_args, extra_postargs, pp_opts)
        finally:
            # register being done processing
            with _global_lock:
                _processing_files.remove(obj)

    for o in build.items():
        single_compile(o)

    # Return *all* object filenames, not just the ones we just built.
    return objects

replace_method(CCompiler, 'compile', CCompiler_compile)


cc = CC('my_module')
# Uncomment the following line to print out the compilation steps
cc.verbose = True

@cc.export('multf', 'f8(f8, f8)')
@cc.export('multi', 'i4(i4, i4)')
def mult(a, b):
    return a * b

@cc.export('square', 'f8(f8)')
def square(a):
    return a ** 2

cc.compile()

pmiettinen · 2019-05-16T13:03:18Z

Next problem. tox/py35 environment doesn't recognize for which Python version the parse_jit module is built and tries to use parse_jit.so built for py27 when it should trigger a build for parse_jit.cpython-35m-x86_64-linux-gnu.so and use it as is the case on native py35 environment.

pmiettinen · 2019-05-16T13:05:48Z

Actual integration to distutils in case of numba needs to be investigated. Main problem being that libsbp uses actually setuptools and not distutils so the numba example is not applicable as-is. Might need some monkeypatching also there.

pmiettinen · 2019-05-17T07:01:09Z

Next some problem with the benchmark script:
ERROR: InvocationError for command /home/travis/build/swift-nav/libsbp/python/../test_data/benchmark.sh /home/travis/build/swift-nav/libsbp/haskell (exited with code 1)

silverjam

Looks great! Just a few nit and questions.

silverjam · 2019-05-22T21:30:37Z

python/setup.py

+        INSTALL_REQUIRES += [i.strip() for i in f.readlines()]
+
+    with open(os.path.join(filedir, 'setup_requirements.txt')) as f:
+        INSTALL_REQUIRES += [i.strip() for i in f.readlines()]


Do we want setup_requirements.txt in INSTALL_REQUIRES? Does this make numba and friends a library dependency? Is there an equivalent "build requirements"?

I need to revisit this. I wasn't feeling I was quite done with the thought process with this. It's complicated to make a clean solution that caters for all the use cases.

I think the main points are close to:

with sdist package these requirements are needed as you are building sbp and the parse_jit module from the sources

with bdist_wheel package these requirements are not needed but the wheel needs to be built and deployed for each Python version separately

sdist is not uploaded to PyPi so I'll just add the version specific wheels and remove the setup_requirements from the package.

silverjam · 2019-05-22T21:31:10Z

python/sbp/constants.py

+# device.
+SENDER_ID = 0x42
+
+_crc16_tab = [


Suggested change

_crc16_tab = [

crc16_tab = [

silverjam · 2019-05-22T21:31:35Z

python/sbp/jit/parse.py

+
+from sbp.constants import SENDER_ID as _SENDER_ID
+from sbp.constants import SBP_PREAMBLE as _SBP_PREAMBLE
+from sbp.constants import _crc16_tab


Suggested change

from sbp.constants import _crc16_tab

crc16_tab = [

silverjam · 2019-05-22T21:31:51Z

python/sbp/jit/parse.py

+cc = CC(module_name)
+cc.verbose = True
+
+crc16_tab = np.array(_crc16_tab, dtype=np.uint16)


Suggested change

crc16_tab = np.array(_crc16_tab, dtype=np.uint16)

np_crc16_tab = np.array(_crc16_tab, dtype=np.uint16)

silverjam · 2019-05-22T21:32:13Z

python/sbp/jit/parse.py

+  """CRC16 implementation acording to CCITT standards."""
+  for index in range(offset, offset + length):
+    data = buf[index]
+    lookup = crc16_tab[((nb.u2(crc) >> 8) & nb.u2(0xFF)) ^ (data & nb.u2(0xFF))]


Suggested change

lookup = crc16_tab[((nb.u2(crc) >> 8) & nb.u2(0xFF)) ^ (data & nb.u2(0xFF))]

lookup = np_crc16_tab[((nb.u2(crc) >> 8) & nb.u2(0xFF)) ^ (data & nb.u2(0xFF))]

silverjam · 2019-05-22T21:32:51Z

python/sbp/msg.py


+from sbp.constants import SENDER_ID as _SENDER_ID
+from sbp.constants import SBP_PREAMBLE as _SBP_PREAMBLE
+from sbp.constants import _crc16_tab


Suggested change

from sbp.constants import _crc16_tab

from sbp.constants import crc16_tab

silverjam · 2019-05-22T21:33:16Z

python/sbp/msg.py

+    parse_jit = importlib.import_module('sbp.jit.' + parse_jit_name)
+
+
+crc16_tab = np.array(_crc16_tab, dtype=np.uint16)


Suggested change

crc16_tab = np.array(_crc16_tab, dtype=np.uint16)

np_crc16_tab = np.array(crc16_tab, dtype=np.uint16)

silverjam · 2019-05-22T21:33:32Z

python/sbp/msg.py

  """CRC16 implementation acording to CCITT standards."""
  for ch in bytearray(s):  # bytearray's elements are integers in both python 2 and 3
-    crc = ((crc << 8) & 0xFFFF) ^ _crc16_tab[((crc >> 8) & 0xFF) ^ (ch & 0xFF)]
+    crc = ((crc << 8) & 0xFFFF) ^ crc16_tab[((crc >> 8) & 0xFF) ^ (ch & 0xFF)]


Suggested change

crc = ((crc << 8) & 0xFFFF) ^ crc16_tab[((crc >> 8) & 0xFF) ^ (ch & 0xFF)]

crc = ((crc << 8) & 0xFFFF) ^ np_crc16_tab[((crc >> 8) & 0xFF) ^ (ch & 0xFF)]

silverjam · 2019-05-22T21:34:20Z

python/sbp/jit/parse.py

+                      include_dirs=None, debug=0, extra_preargs=None,
+                      extra_postargs=None, depends=None):
+    """
+    Compile one or more source files.


I think we can delete their docs, and maybe just insert a link to the original source?

Numba code is built when the module is called for the first time. This way the code will be optimized for the processor at hand instead of more generic prebuild package. In following import calls build step is not needed. This means that numba is still a requirement.

pmiettinen · 2019-05-31T11:08:14Z

@silverjam to review the latest changes and decide on the merging.

silverjam · 2019-06-03T18:41:56Z

Changes look good but I can't figure out how to build on Windows, will try to spend a few minutes working this out, otherwise we'll need to revisit later.

We need to work around a permission denied error on Windows.

silverjam · 2019-06-05T20:38:22Z

.travis.yml

        - sudo apt-get -y -o Dpkg::Options::="--force-confnew" install docker-ce
        - sudo pip install tox
-        - git clone -b master https://github.com/swift-nav/piksi_tools.git ../piksi_tools
+        - git clone -b pmiettinen/esd-1156-numba-deployment https://github.com/swift-nav/piksi_tools.git ../piksi_tools


fix after merge

pmiettinen changed the title ~~[WIP] Integrate CFFI into setuptools [ESD-1156]~~ [WIP] Integrate CFFI and numba into setuptools [ESD-1156] May 14, 2019

pmiettinen force-pushed the pmiettinen/esd-1156-numba-deployment branch 4 times, most recently from 9edaa98 to 0e3b31d Compare May 15, 2019 09:36

pmiettinen force-pushed the pmiettinen/esd-1156-numba-deployment branch from 6738e80 to eeba8e3 Compare May 16, 2019 12:15

pmiettinen force-pushed the pmiettinen/esd-1156-numba-deployment branch from eeba8e3 to 4fe36a1 Compare May 17, 2019 06:20

pmiettinen mentioned this pull request May 17, 2019

Update sbp.jit references swift-nav/piksi_tools#1050

Merged

pmiettinen force-pushed the pmiettinen/esd-1156-numba-deployment branch 2 times, most recently from a8db61d to e15ec3f Compare May 17, 2019 13:23

benjaminaltieri requested a review from silverjam May 17, 2019 18:01

pmiettinen force-pushed the pmiettinen/esd-1156-numba-deployment branch from e15ec3f to e859e93 Compare May 22, 2019 08:42

pmiettinen changed the title ~~[WIP] Integrate CFFI and numba into setuptools [ESD-1156]~~ Integrate numba into setuptools [ESD-1156] May 22, 2019

silverjam suggested changes May 22, 2019

View reviewed changes

pmiettinen added 3 commits May 27, 2019 09:18

Integrate CFFI into setuptools

72b60f4

Upgrade setuptools

62a9cc4

tox: remove explicit call to parse_float.py

46c2fbe

pmiettinen added 12 commits May 27, 2019 09:18

Add sbp.jit to packages and rework parse_float_c importing

b030fcc

Distinct module names for different Python versions

33cd89f

Remove CFFI dependency

6f17e36

piksi_tools dev branch

3a01cbe

Update benchmark threshold to 1.4

1f7c7d6

Treat as external module in setup

aa3f287

Remove parse_float module

145009e

Resolve setup.py requirements

ad4cfd9

Rename CRC table

37a1e3a

Cleanup

e341a7e

Build separate wheel for each supported Python version

1e09b98

pmiettinen force-pushed the pmiettinen/esd-1156-numba-deployment branch from c7628b9 to 1e09b98 Compare May 27, 2019 08:30

Jason Mobarak and others added 11 commits June 3, 2019 14:26

Quick and dirty port of deploy.bash to deploy.py for Windows.

42bcd8b

temp 2.5.6

d7e117c

Fix vesion reading on Python 2.7

5559a70

Don't use context version of temp dir

2086434

We need to work around a permission denied error on Windows.

Fix sbp._version issue without reload

23cdc63

Support USE_TEST_PYPI flag

0c76b49

Issue warning for test PyPI

c8ec820

Specify python3 for *nix

1d59df1

Install gcc for Linux

1a4f8c5

Add support for ARM Linux

cdcb901

Docs, ability to build an "any" wheel

7d477bd

silverjam reviewed Jun 5, 2019

View reviewed changes

silverjam approved these changes Jun 5, 2019

View reviewed changes

silverjam merged commit 0ef6a03 into master Jun 5, 2019

silverjam deleted the pmiettinen/esd-1156-numba-deployment branch June 5, 2019 20:39

	crc16_tab = np.array(_crc16_tab, dtype=np.uint16)
	np_crc16_tab = np.array(_crc16_tab, dtype=np.uint16)

	lookup = crc16_tab[((nb.u2(crc) >> 8) & nb.u2(0xFF)) ^ (data & nb.u2(0xFF))]
	lookup = np_crc16_tab[((nb.u2(crc) >> 8) & nb.u2(0xFF)) ^ (data & nb.u2(0xFF))]

	from sbp.constants import _crc16_tab
	from sbp.constants import crc16_tab

		parse_jit = importlib.import_module('sbp.jit.' + parse_jit_name)


		crc16_tab = np.array(_crc16_tab, dtype=np.uint16)

	crc16_tab = np.array(_crc16_tab, dtype=np.uint16)
	np_crc16_tab = np.array(crc16_tab, dtype=np.uint16)

	crc = ((crc << 8) & 0xFFFF) ^ crc16_tab[((crc >> 8) & 0xFF) ^ (ch & 0xFF)]
	crc = ((crc << 8) & 0xFFFF) ^ np_crc16_tab[((crc >> 8) & 0xFF) ^ (ch & 0xFF)]

Integrate numba into setuptools [ESD-1156] #687

Integrate numba into setuptools [ESD-1156] #687

Uh oh!

Conversation

pmiettinen commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmiettinen commented May 15, 2019

Uh oh!

pmiettinen commented May 15, 2019

Uh oh!

pmiettinen commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmiettinen commented May 15, 2019

Uh oh!

pmiettinen commented May 16, 2019

Uh oh!

pmiettinen commented May 16, 2019

Uh oh!

pmiettinen commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmiettinen commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmiettinen commented May 16, 2019

Uh oh!

pmiettinen commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmiettinen commented May 16, 2019

Uh oh!

pmiettinen commented May 16, 2019

Uh oh!

pmiettinen commented May 17, 2019

Uh oh!

silverjam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmiettinen May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmiettinen commented May 31, 2019

Uh oh!

silverjam commented Jun 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pmiettinen commented May 14, 2019 •

edited

Loading

pmiettinen commented May 15, 2019 •

edited

Loading

pmiettinen commented May 16, 2019 •

edited

Loading

pmiettinen commented May 16, 2019 •

edited

Loading

pmiettinen commented May 16, 2019 •

edited

Loading

pmiettinen May 27, 2019 •

edited

Loading