Skip to content

Conversation

@ljbade
Copy link
Contributor

@ljbade ljbade commented Aug 6, 2019

No description provided.

@ljbade ljbade requested a review from martin-swift August 6, 2019 02:52
desc: |
Quality of the troposphere data. Encoded following RTCM DF389
specifcation but as TECU instead of m.
specifcation in units of m.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it meters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the CLAS spec:
image

From RTCM:
image

So they are basically reusing the SSR URA formula which takes the index (in the u8) and returns a value in metres.

We could try copying that formula into the YAML but it wouldn't look pretty.

I'm open to alternative wordings if you think there is something clearer we could use.

desc: |
Quality of the STEC data. Encoded following RTCM DF389 specifcation
but as TECU instead of m.
but in units of TECU instead of m.
Copy link
Contributor

@martin-swift martin-swift Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's some weird coded value that isn't TECU or meters. still not quite sure how to interpret that spec...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the CLAS spec:
image

From RTCM:
image

In this case my reading is that they want you to use the SSR URA formula, but just replace metres with TECU, so it keeps the same numerical value, just interpreted differently.

I'm open to alternative wordings if you think there is something clearer we could use.

@silverjam
Copy link
Contributor

silverjam commented Aug 26, 2019

@ljbade @martin-swift generated code should be ready to go

@ljbade
Copy link
Contributor Author

ljbade commented Aug 26, 2019

@silverjam thank you!

@ljbade ljbade merged commit 3931104 into master Sep 2, 2019
@ljbade ljbade deleted the ljbade/fix-clas branch September 2, 2019 05:44
@ljbade
Copy link
Contributor Author

ljbade commented Sep 2, 2019

@silverjam after merging this I have discovered the c code didn't generate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants