libsbp version 2.7.0 #730
Merged
libsbp version 2.7.0 #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jbangelo FYI, the rust generator doesn't appear to produce stable output, the mod.rs in this release is jumbled from the previous time rust was generated. |
Contributor
|
Odd. Looks like I'm able to reproducible locally. Will look into it when I have time. Do the other generators need to do anything special to keep their output consistent? Seems like it could be inconsistent ordering of the message definitions. |
Contributor
Author
|
I think the java generator had similar issues, a fix is probably as simple just sorting the list of keys you get back from a dictionary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.