[STAR-789] Add proposed Protection Level message #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbangelo
force-pushed
the
jbangelo/STAR-789-add-pl-message
branch
from
8e4498f to
b08a501
Compare
lloydmaza
suggested changes
Oct 11, 2019
Contributor
lloydmaza
left a comment
lloydmaza
left a comment
There was a problem hiding this comment.
Message definition basically looks good to me, besides a couple of small nits. Just make sure to update the message description before merging anything.
jbangelo
force-pushed
the
jbangelo/STAR-789-add-pl-message
branch
from
15242b2 to
f14b46f
Compare
scarcanague
reviewed
Oct 15, 2019
Contributor
scarcanague
left a comment
scarcanague
left a comment
There was a problem hiding this comment.
A few comments as per @denniszollo suggestions
jbangelo
force-pushed
the
jbangelo/STAR-789-add-pl-message
branch
2 times, most recently
from
130b747 to
688b9a7
Compare
lloydmaza
approved these changes
Oct 17, 2019
Contributor
lloydmaza
left a comment
lloydmaza
left a comment
There was a problem hiding this comment.
The changes I advised have been implemented, so I'm glad to give this the green check.
It would be good to gather feedback from some other voices to see if the changes to the message definition are satisfactory for this initial implementation.
scarcanague
approved these changes
Oct 17, 2019
Contributor
scarcanague
left a comment
scarcanague
left a comment
There was a problem hiding this comment.
1 final comment but looks good otherwise
jbangelo
force-pushed
the
jbangelo/STAR-789-add-pl-message
branch
from
688b9a7 to
68f9c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split this into two commits. The first contains the update to the spec, the second contains all of the regenerated code.