rust: nom parsing fix-up for eof error [INFRA-125] #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 10, 2020 23:56
silverjam
changed the title
jbangelo
approved these changes
Mar 23, 2020
Contributor
jbangelo
left a comment
jbangelo
left a comment
There was a problem hiding this comment.
Good catch! Would we want to up the version number for this?
Contributor
Author
You mean make a new release? Yeah, I'll do that sometime this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently nom has two cases were it can return "not enough data", there's an
Incompletereturn type and an EOF error. I'm not sure in what cases it would return one vs the other, but the EOF error here would cause us the drop messages in the Rust version of sbp2json (which was surfaced while testing the Rust variant of json2sbp).TODO: