README typos, pin deps for sbp2json in Cargo.lock #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverjam
changed the title
jbangelo
approved these changes
Jun 3, 2020
|
|
||
| # rust | ||
| Cargo.lock | ||
| /Cargo.lock |
Contributor
There was a problem hiding this comment.
Is this needed? Aren't you copying the Cargo.lock file into the rust/ sub directory in the benchmark script?
Contributor
Author
There was a problem hiding this comment.
There's a top-level Cargo.lock that we need to ignore (I think) so that we don't have a Cargo.lock if libsbp is pulled in as a dependency from git. Then there's a Cargo.lock that's in rust/sbp2json/Cargo.lock that we've checked in to pin deps, this is what gets copied to the benchmark build script's build directory. The benchmark build script is a little misnamed at the moment... since it's used for building the binaries we distribute for Linux, as well as the benchmark process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.