Skip to content

Fix bugs in Java array decoding #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Fix bugs in Java array decoding #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions java/src/com/swiftnav/sbp/SBPMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public int[] getArrayofS8(int n) {
}

public int[] getArrayofS16() {
return getArrayofS16(buf.remaining());
return getArrayofS16(buf.remaining() / 2);
}
public int[] getArrayofS16(int n) {
int[] ret = new int[n];
Expand All @@ -177,7 +177,7 @@ public int[] getArrayofS16(int n) {
}

public int[] getArrayofU16() {
return getArrayofU16(buf.remaining());
return getArrayofU16(buf.remaining() / 2);
}
public int[] getArrayofU16(int n) {
int[] ret = new int[n];
Expand All @@ -187,7 +187,7 @@ public int[] getArrayofU16(int n) {
}

public float[] getArrayofFloat() {
return getArrayofFloat(buf.remaining());
return getArrayofFloat(buf.remaining() / Float.BYTES);
}
public float[] getArrayofFloat(int n) {
float [] ret = new float[n];
Expand All @@ -197,7 +197,7 @@ public float[] getArrayofFloat(int n) {
}

public double[] getArrayofDouble() {
return getArrayofDouble(buf.remaining());
return getArrayofDouble(buf.remaining() / Double.BYTES);
}
public double[] getArrayofDouble(int n) {
double [] ret = new double[n];
Expand Down