Skip to content

Conversation

@reimerix
Copy link
Contributor

@reimerix reimerix commented Sep 30, 2020

This PR changes the solution meta message according to @switanis inputs:

  • Remove the n_sats field
  • Remove alignment_status field (the plan is to start using some bits of MSG_INS_STATUS for this in the future)
  • Add tow field
  • Replace TOW of last used GNSS pos/velocity fields with an age_gnss field.

@denniszollo
Copy link
Contributor

LGTM. I prefer that we squash down to two commits, one with change to yaml, one with the generated files.

@reimerix reimerix force-pushed the reimerix/sr-146/solution-meta-updates branch from 5ffa6b8 to eee6644 Compare October 5, 2020 10:24
Copy link
Contributor

@GuillaumeDec GuillaumeDec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@dgburr
Copy link
Contributor

dgburr commented Oct 6, 2020

Which starling release will this changed message be introduced in?

@dgburr
Copy link
Contributor

dgburr commented Oct 6, 2020

The TOW field is needed to be able to match information from the fusion stream with information from the PVT stream (e.g. PL values).

@reimerix
Copy link
Contributor Author

reimerix commented Oct 6, 2020

Which starling release will this changed message be introduced in?

@dgburr We're targeting a release with the general 1.2 release slated for the end of this week.

@reimerix reimerix merged commit 77cc561 into master Oct 6, 2020
@reimerix reimerix deleted the reimerix/sr-146/solution-meta-updates branch October 6, 2020 15:03
@dgburr
Copy link
Contributor

dgburr commented Oct 6, 2020

Is the new 'tow' field guaranteed to have a corresponding epoch in the PVT stream? Or is this possible:

SBP_MSG_GPS_TIME_GNSS with tow = 999 (due to ublox rounding)
SBP_SOLN_META with tow = 1000

@switanis
Copy link
Contributor

switanis commented Oct 6, 2020

I hope SOLN META TOW is the same as TOW in all other messages in the BEST POS group.
xxx_GNSS may have different TOW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants