This repository was archived by the owner on Aug 5, 2024. It is now read-only.
scott/peddie/eric changes #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to pattern-match on 'Just' everywhere we looked up a variable binding in the type checker. This would result in UM's 'fail' being invoked. This patch replaces the binding threeple with a dedicated datatype and handles lookup failure with a more useful message in one place.
src/Language/Plover/Unify.hs
Outdated
| unify pos tyb tyc | ||
| typeCheck (Specialize pos v cases dflt) = do | ||
| Just (vpos, vty) <- getBinding v | ||
| VB pos vty _ <- getBinding v |
Contributor
There was a problem hiding this comment.
Oops, this is a bug -- and I think I can do VB _ vty _.
Contributor
Author
|
all looks good. @ejconlon do you want to look over it before we merge? |
Contributor
Author
|
commit d315a8c ensures that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets collect improvements to the docs and any changes you guys make here so we can all see them and talk them over