Make cereal thread safe by default #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armallen
approved these changes
Aug 28, 2025
RReichert
added a commit
to swift-nav/albatross
that referenced
this pull request
Aug 29, 2025
# Changes If you read the [Cereal library documentation](https://uscilab.github.io/cereal/thread_safety.html), you will be shocked that the default behavior for the library is to not have it run in a multithreaded manner. It apparently has a global variable that it uses to track information and it works nicely in a single threaded application, however in a mutlithreaded application is can be problematic. The changes here changes the default behavior so that this global variable is thread safe and doesn't cause any undefined behavior. # Related PR swift-nav/rules_swiftnav#178 - bazel implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If you read the Cereal library documentation, you will be shocked that the default behavior for the library is to not have it run in a multithreaded manner. It apparently has a global variable that it uses to track information and it works nicely in a single threaded application, however in a mutlithreaded application is can be problematic.
The changes here changes the default behavior so that this global variable is thread safe and doesn't cause any undefined behavior.