Allow usage of strip_include_prefix in cc_stamped_library #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin4861
force-pushed
the
martin4861/use-strip_include_prefix-in-stamped-lib
branch
from
9b79644 to
692692a
Compare
sbmueller
approved these changes
Sep 2, 2025
martin4861
deleted the
martin4861/use-strip_include_prefix-in-stamped-lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of includes in
cc_stamped_librarytargets is incorrectly propagating header paths with-isystem, which suppresses compiler warnings in dependent targets. To resolve this, thecc_stamped_librarymacro inrules_swiftnavmust be updated to supportstrip_include_prefixand remove its dependency on theincludesattribute.Tested in