Skip to content

Remove stack protector warnings flags #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2025
Merged

Remove stack protector warnings flags #184

merged 3 commits into from
Sep 11, 2025

Conversation

@armallen
Copy link
Contributor

@armallen armallen commented Sep 10, 2025 •
edited
Loading

Stack protector warning flag is removed

Tested locally on mac, and using Jenkins modern docker image (gcc11, bazel build --config=system).

Tested in CI:

@armallen armallen marked this pull request as ready for review September 10, 2025 14:05
@armallen armallen requested a review from a team as a code owner September 10, 2025 14:05
sbmueller
sbmueller approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@sbmueller sbmueller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed in the coding guidelines CCB today.
@armallen did you test if this actually resolves your issue?

@armallen
Copy link
Contributor Author

armallen commented Sep 10, 2025

As agreed in the coding guidelines CCB today. @armallen did you test if this actually resolves your issue?

Yes it does, I guess it's only because of the Warning flag being disabled, I'll put back the fstack-protector in toolchains and test again

@sbmueller sbmueller self-requested a review September 10, 2025 16:33
@armallen armallen changed the title Remove stack protector Remove stack protector warnings flags Sep 10, 2025
@woodfell woodfell merged commit bebebff into main Sep 11, 2025
2 checks passed
@woodfell woodfell deleted the armallen/no-error-stack-protector branch September 11, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RReichert RReichert RReichert approved these changes

@martin4861 martin4861 martin4861 approved these changes

@woodfell woodfell woodfell approved these changes

@sbmueller sbmueller Awaiting requested review from sbmueller

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@armallen @RReichert @martin4861 @sbmueller @woodfell