This repository was archived by the owner on Nov 23, 2021. It is now read-only.
Add Semaphores to fix TSAN warnings#108
Merged
gtaban merged 3 commits intoswift-server:developfrom Jan 8, 2018
Merged
Conversation
Semaphores to track if abort() has been called Semaphores to track if cleanup() has been called and only let it get called once
added 2 commits
January 8, 2018 10:57
gtaban
approved these changes
Jan 8, 2018
Collaborator
gtaban
left a comment
gtaban
left a comment
There was a problem hiding this comment.
Reviewed with Carl and he made appropriate updates. All looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm going ahead and putting this PR in (as a result of this request from Daniel Dunbar on the mailing list) while the linux-specific tests for #96 tests are still being worked on.