This repository was archived by the owner on Nov 23, 2021. It is now read-only.
TLS integration#93
Closed
gtaban wants to merge 1 commit intoswift-server:developfrom
Closed
Conversation
Contributor
|
Deferring this until after #96 is completed and merged (and if that doesn't happen, we can reopen this one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will give support to HTTPS. Tests have been added for both self-signed and CA-signed certs on Linux and macOS.
The TLS code currently sits in:
// protocol definitions and data types
https://github.com/gtaban/security.git
// implementation using OpenSSL on Linux and SecureTransport on macOS
https://github.com/gtaban/TLSService.git
Once the HTTPS work is integrated, TLS repos can be merged under swift-server.
NB/ Previous PR before I smashed my git branches: #78