Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Conversation

@tomerd
Copy link
Collaborator

@tomerd tomerd commented Jun 7, 2022

motivation: print crash trace on segmentaiton fault

changes:

  • include SIGSEGV in the default signals trapped
  • update and improve tests

@tomerd tomerd requested review from ktoso, weissi and yim-lee June 7, 2022 01:59
@tomerd tomerd mentioned this pull request Jun 7, 2022
@tomerd
Copy link
Collaborator Author

tomerd commented Jun 7, 2022

closes #47

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice addition - might want to release a version with this right away?

motivation: print crash trace on segmentaiton fault

changes:
* include SIGSEGV in the default signals trapped
* update and improve tests
@tomerd tomerd added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Jun 7, 2022
Copy link
Collaborator

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomerd tomerd merged commit baf9597 into swift-server:main Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants