Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Conversation

@tomerd
Copy link
Collaborator

@tomerd tomerd commented Jun 14, 2022

motivation: make sure stderr buffered is printed out before program exits (in case stderr is buffered)

changes: explicitly call fflush after writing the backtraces

motivation: make sure stderr buffered is printed out before program exits

changes: explicitly call fflush after writing the backtraces
@tomerd tomerd requested review from weissi and yim-lee June 14, 2022 16:04
@tomerd tomerd mentioned this pull request Jun 14, 2022
@tomerd tomerd changed the title flush stderr after printing back traces flush stderr after printing backtraces Jun 14, 2022
Copy link
Collaborator

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems like a good idea! Thank you

@weissi weissi merged commit f25620d into swift-server:main Jun 14, 2022
@tomerd tomerd added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants